Add nota icon
ClosedPublic

Authored by mbruchert on Feb 8 2020, 5:24 PM.

Details

Reviewers
camiloh
ngraham
ndavis
Group Reviewers
VDG
Commits
R266:c40434acbf70: Add nota icon

Diff Detail

Repository
R266 Breeze Icons
Branch
nota (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22246
Build 22264: arc lint + arc unit
mbruchert created this revision.Feb 8 2020, 5:24 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 8 2020, 5:24 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
mbruchert requested review of this revision.Feb 8 2020, 5:24 PM
ngraham accepted this revision.Mar 19 2020, 6:54 PM
ngraham added subscribers: ndavis, ngraham.

LGTM. @ndavis?

This revision is now accepted and ready to land.Mar 19 2020, 6:54 PM
ndavis requested changes to this revision.Mar 20 2020, 4:39 AM

The dotted lines are placed on half pixels, which we should avoid doing.
Depending on the look you're going for, you could do either one of the following:

  • Align the 1px thick lines to the pixel grid
  • Expand the dotted lines to 2px thickness and set their opacity to 50%. This preserves the current look and make it continue to look that way at larger scales.
This revision now requires changes to proceed.Mar 20 2020, 4:39 AM
mbruchert updated this revision to Diff 78083.Mar 20 2020, 11:30 AM
  • update dotted lines
ndavis accepted this revision.Mar 20 2020, 11:32 AM

LGTM

This revision is now accepted and ready to land.Mar 20 2020, 11:32 AM
ndavis retitled this revision from nota to Add nota icon.Mar 20 2020, 11:33 AM
This revision was automatically updated to reflect the committed changes.