Ki18n: Convert license headers to SPDX statements
Needs ReviewPublic

Authored by cordlandwehr on Sat, Feb 8, 12:58 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Maniphest Tasks
T11550: Add SPDX License markers
Summary

Convert license statements to SPDX and add license text files in LICENSES
folder as required by the REUSE specification.

Diff Detail

Repository
R249 KI18n
Branch
spdx
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22428
Build 22446: arc lint + arc unit
cordlandwehr created this revision.Sat, Feb 8, 12:58 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSat, Feb 8, 12:58 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
cordlandwehr requested review of this revision.Sat, Feb 8, 12:58 PM

some headers have 3 leading whitespaces, some 4. Can you clarify?

LICENSES/LGPL-3.0-only.txt
16–18

why are there so many empty lines?

src/gettext.h
1–5

extra space after "Free Software Foundation"

cordlandwehr added inline comments.Thu, Feb 13, 11:01 AM
LICENSES/LGPL-3.0-only.txt
16–18

Actually, I have no idea. But according to the REUSE specification, the license files must no be changed and used exactly as provided by SPDX.
All license files, except the LicenseRef files, of course, were downloaded via the "reuse download" tool and thus are the unmodified versions as provided by SPDX.

Unify license comment header style

Remove unneeded whitespace

cordlandwehr marked an inline comment as done.Thu, Feb 13, 11:10 AM
cgiboudeaux added inline comments.Thu, Feb 13, 11:34 AM
LICENSES/LGPL-3.0-only.txt
16–18

well, the SPDX text doesn't have these extra lines:
https://spdx.org/licenses/LGPL-3.0-only.html#licenseText

cordlandwehr added inline comments.Thu, Feb 13, 12:09 PM
LICENSES/LGPL-3.0-only.txt
16–18

Just tested again with the reuse tool and it actually provides the license with these empty lines. I will report an issue on the reuse tool's bug tracker. For now, I would prefer to stick with these (strange) empty lines and update the license text only when REUSE is updating their tooling.

Link to issue on reuse-tool tracker regarding empty lines in LGPL-3.0-only license text: https://github.com/fsfe/reuse-tool/issues/178