show an OSD on display button press
ClosedPublic

Authored by sebas on Sep 8 2016, 11:45 PM.

Details

Summary

Show the plasma OSD with icon "preferences-desktop-display-randr" and
text when the display button has been pressed.

When only one displays is connected, "No External Display" is connected.
When more displays are connected, "Changing Screen Layout" is shown.

This is pretty bare-bones, it doesn't show what kind of setup it will
choose now, or next. This could be done by improving Generator, now,
however. The problem is that when we're applying a new config, displays
will flicker due to being mode-set, so the OSD isn't all that useful
since the screens will settle down.
It is useful in case of only one screen, since it gives feedback to a
button that otherwise just appears do nothing.

I think this could be enhanced in the future by giving the opportunity
to pick a layout. For 5.8, this brings a noticeable improvement and lays
the base for further work.

Test Plan

manually tested both cases (1 and 2 screens)

Diff Detail

Repository
R104 KScreen
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sebas updated this revision to Diff 6567.Sep 8 2016, 11:45 PM
sebas retitled this revision from to show an OSD on display button press.
sebas updated this object.
sebas edited the test plan for this revision. (Show Details)
sebas added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptSep 8 2016, 11:45 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
graesslin added inline comments.
kded/daemon.cpp
235–237

One time it's "Display", one time it's "Screen". I think we should use the same wording.

sebas added a comment.Sep 9 2016, 8:31 AM

Display means one monitor, screen the combination of all. That is consistent with how we use it elsewhere as far as I can tell.

mart accepted this revision.Sep 9 2016, 9:25 AM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Sep 9 2016, 9:25 AM
This revision was automatically updated to reflect the committed changes.