Differential D27157

[KConfigLoader] Code cleanup
ClosedPublic
Actions

Authored by ahmadsamir on Feb 4 2020, 6:19 PM.

Details

Reviewers
apol
dfaure
Group Reviewers
Frameworks
Commits
R237:9dec6961b3ae: [KConfigLoader] Code cleanup
Summary
  • Drop redundant args to startElement()/endEelement()
  • Use range-for
  • Drop ConfigLoaderHandler methods that weren't used anywhere AFAICS and ConfigLoaderHandler is private API
Test Plan

make && ctest

Diff Detail

Repository
R237 KConfig
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahmadsamir created this revision.Feb 4 2020, 6:19 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 4 2020, 6:19 PM
ahmadsamir requested review of this revision.Feb 4 2020, 6:19 PM
ahmadsamir updated this revision to Diff 75029.Feb 5 2020, 8:10 AM

Tweak commit message

dfaure accepted this revision.Feb 7 2020, 10:35 PM
This revision is now accepted and ready to land.Feb 7 2020, 10:35 PM
Closed by commit R237:9dec6961b3ae: [KConfigLoader] Code cleanup (authored by ahmadsamir). · Explain WhyFeb 8 2020, 6:45 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 75210

View Options

src/gui/kconfigloader.cpp

Loading...
View Options

src/gui/kconfigloaderhandler_p.h

Loading...