[Applet]Fix device label problems
AbandonedPublic

Authored by gvgeo on Feb 3 2020, 4:14 PM.

Details

Reviewers
drosca
ngraham
davidedmundson
Group Reviewers
Plasma
VDG
Summary

Limit label maximum width, to avoid breaking UI.
Change label to use plasma components 3, for theme color compatibility.
Use of implicit sizes, to avoid binding loops.

Note: Didn't make use fillWidth because we need the button area to be
only on the text, and not in the empty area.

Test Plan

Use applet outside of systemtray and limit it's width.
If device description is not long enough, enable in the configuration
"Add virtual output device for simultaneous output on all local sound cars".
Before: Hamburger menu moves to the right, and there is no eliding.
After: Proper display.

BUG: 417074
BUG: 417106

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Branch
labelWidth2 (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22011
Build 22029: arc lint + arc unit
gvgeo created this revision.Feb 3 2020, 4:14 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 3 2020, 4:14 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
gvgeo requested review of this revision.Feb 3 2020, 4:14 PM
gvgeo abandoned this revision.Feb 3 2020, 4:15 PM

A mistake...