[System Tray] Initially set correct category for plasmoids
ClosedPublic

Authored by broulik on Jan 31 2020, 2:49 PM.

Details

Summary

The category was only used for proper Plasma::Applet instances but not unloaded plasmoids from pure metadata.

BUG: 416947
FIXED-IN: 5.18.0

Test Plan
  • I dont have any plasmoids that shift from Misc to their proper category once loaded anymore

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Jan 31 2020, 2:49 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 31 2020, 2:49 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jan 31 2020, 2:49 PM
broulik added reviewers: Plasma, kmaterka.
kmaterka accepted this revision.Jan 31 2020, 3:06 PM

I definitely need to split D26992 into smaller chunks :) I had it fixed, but obviously D26992 can't be merged for 5.18.

There is a second inconsistency, but it is not a serious problem. There are some category overrides in main.qml, if you think it is a problem I will prepare separate revision with something like this:

static const QHash<QString, QString> s_categoryOverride = {
    {QStringLiteral("org.kde.discovernotifier"), QStringLiteral("SystemServices")},
    {QStringLiteral("org.kde.plasma.networkmanagement"), QStringLiteral("Hardware")},
    {QStringLiteral("org.kde.kdeconnect"), QStringLiteral("Hardware")},
    {QStringLiteral("org.kde.plasma.keyboardindicator"), QStringLiteral("Hardware")},
    {QStringLiteral("touchpad"), QStringLiteral("Hardware")}
};
This revision is now accepted and ready to land.Jan 31 2020, 3:06 PM

category overrides in main.qml

I think those should go away and have the SNI/plasmoid in the right category. I think most of them are obsolete already anyway, e.g. org.kde.plasma.networkmanagement is Hardware in its metadata

This revision was automatically updated to reflect the committed changes.