Clip the flickable parent item
ClosedPublic

Authored by ahiemstra on Jan 30 2020, 11:58 AM.

Details

Summary

Without clipping the contents, they can draw stuff outside of the scrollview
bounds, leading to issues with content being drawn underneath the scrollbar,
among others.

BUG: 416877

Test Plan

Before:

After:

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahiemstra created this revision.Jan 30 2020, 11:58 AM
Restricted Application added a project: Kirigami. · View Herald TranscriptJan 30 2020, 11:58 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ahiemstra requested review of this revision.Jan 30 2020, 11:58 AM
ahiemstra edited the test plan for this revision. (Show Details)Jan 30 2020, 12:01 PM
apol added a subscriber: apol.Jan 30 2020, 2:10 PM

after looks cropped now, are you sure this is the right fix? (not that it isn't necessary...)

ahiemstra added a comment.EditedJan 30 2020, 2:24 PM

That's because the KCM for some reason does not want to size smaller even when the kcmshell window does get smaller. This is not related to the scrollbar however, I get the same result without the scrollbar:

Since the bug report was specifically about the scrollbar I interpreted it as the overlay being weird, not the actual cutoff.

ngraham accepted this revision.Jan 30 2020, 2:33 PM
ngraham added a subscriber: ngraham.

Yeah the cut-off is a pre-existing issue.

This fixes the visual issue I've been seeing with the System Tray configuration view and the Notifications KCM's applications list. +1.

This revision is now accepted and ready to land.Jan 30 2020, 2:33 PM
apol added a comment.Jan 30 2020, 2:51 PM

The fact that isn't preexistent doesn't change that if the flicked item were to be placed properly, clipping wouldn't be necessary

mart accepted this revision.Jan 31 2020, 2:21 PM
This revision was automatically updated to reflect the committed changes.

Note that I did spend some time investigating what causes the clipping to be needed in the first place, but that looks like an issue deep in kcmshell5, which allows any kcm to be resized to below its minimum size. This also leads to issues with other KCMs like https://bugs.kde.org/show_bug.cgi?id=398797