In D26931#601508, @cgiboudeaux wrote:

In D26931#601505, @cordlandwehr wrote:

Convert to SPDX-FileCopyrightText tags

some files have <year> by <author>, can I suggest removing this "by"?

same question for the extra spaces between authors and email addresses in a couple files

Unify copyright header format

Harbormaster completed remote builds in B21906: Diff 74768.Jan 31 2020, 12:53 PM

krop accepted this revision.Jan 31 2020, 1:50 PM

This revision is now accepted and ready to land.Jan 31 2020, 1:50 PM

Closed by commit R274:11f5cd0390e4: Introduce SPDX license headers (authored by cordlandwehr). · Explain WhyFeb 1 2020, 3:23 PM

This revision was automatically updated to reflect the committed changes.

kossebau added a subscriber: kossebau.Feb 1 2020, 7:11 PM

kossebau added inline comments.

LICENSES/MIT.txt
1	Does the "<year> <copyright holders>" work here?

cordlandwehr added inline comments.Feb 1 2020, 10:09 PM

LICENSES/MIT.txt
1	The statement is correct, it directly comes from the SPDX license text registry and is installed via the "reuse download" tool to ensure that the original header is deployed.

cordlandwehr mentioned this in T11550: Add SPDX License markers.Feb 8 2020, 8:48 AM

cordlandwehr retitled this revision from Introduce SPDX license headers to KIdleTime: Convert license statements to SPDX.Feb 8 2020, 10:37 AM

Revision Contents
Changeset List

		Path
A	M	LICENSES/GPL-2.0-or-later.txt (319 lines)
A	M	LICENSES/LGPL-2.0-only.txt (446 lines)
A	M	LICENSES/MIT.txt (19 lines)
M		examples/KIdleTest.h (23 lines)
M		examples/KIdleTest.cpp (23 lines)
M		examples/main.cpp (23 lines)
M		src/abstractsystempoller.h (20 lines)
M		src/abstractsystempoller.cpp (20 lines)
M		src/kidletime.h (20 lines)
M		src/kidletime.cpp (20 lines)
M		src/plugins/osx/macpoller.h (20 lines)
M		src/plugins/osx/macpoller.cpp (26 lines)
M		src/plugins/windows/windowspoller.h (20 lines)
M		src/plugins/windows/windowspoller.cpp (20 lines)
M		src/plugins/xscreensaver/xscreensaverbasedpoller.h (20 lines)
M		src/plugins/xscreensaver/xscreensaverbasedpoller.cpp (20 lines)
M		src/plugins/xsync/fixx11h.h (28 lines)
M		src/plugins/xsync/xsyncbasedpoller.h (20 lines)
M		src/plugins/xsync/xsyncbasedpoller.cpp (16 lines)
M		src/widgetbasedpoller.h (20 lines)
M		src/widgetbasedpoller.cpp (20 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	74400	892d02b		Jan 26 2020, 5:55 PM	★	★
Diff 2	74452	892d02b	Convert to SPDX-FileCopyrightText tags	Jan 27 2020, 5:55 PM	★	★
Diff 3	74768	892d02b	Unify copyright header format	Jan 31 2020, 12:53 PM	★	★
Diff 4	74834	fd12394	R274:11f5cd0390e4d98dde15e3c43d85136b5b2c3efc	Feb 1 2020, 3:23 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
147161aee25b	684abfb2e1f1	52fb288deb27	Andreas Cord-Landwehr	Unify copyright header format	Jan 31 2020, 12:52 PM
52fb288deb27	c60cbe7d3ef8	4334a0cadaaf	Andreas Cord-Landwehr	Convert to SPDX-FileCopyrightText tags	Jan 27 2020, 5:52 PM
4334a0cadaaf	6bb754127979	892d02b7cdae	Andreas Cord-Landwehr	Introduce SPDX license headers (Show More…)	Jan 26 2020, 5:54 PM