Differential D2693

Standardize Drawer width
ClosedPublic
Actions

Authored by apol on Sep 7 2016, 1:37 PM.

Details

Reviewers
mart
Group Reviewers
Kirigami
Commits
R169:616af4327cc6: Standardize Drawer width
Summary

Make it wider, not dependent in terms of the title size

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol updated this revision to Diff 6513.Sep 7 2016, 1:37 PM
apol retitled this revision from to Standardize Drawer width.
apol updated this object.
apol edited the test plan for this revision. (Show Details)
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami. · View Herald TranscriptSep 7 2016, 1:37 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik added a subscriber: broulik.Sep 7 2016, 1:55 PM

I have to test it how it looks on a phone i agree on the concept, not sure on the implementation as it's potentially breaking on applications

apol added a comment.Sep 7 2016, 3:14 PM
In D2693#50118, @broulik wrote:

I have to test it how it looks on a phone i agree on the concept, not sure on the implementation as it's potentially breaking on applications

How do you foresee it breaking applications? It becomes a reasonably big drawer, if the title doesn't fit it's probably a too big title anyway.

mart edited edge metadata.Sep 8 2016, 6:17 AM

Just want to give it a try on android then i'm happy :)

apol updated this revision to Diff 6538.Sep 8 2016, 11:38 AM
apol edited edge metadata.
  • Fix warnings
mart requested changes to this revision.Sep 9 2016, 1:36 PM
mart edited edge metadata.

it's based upon D2580, can you rebase this upon master?

This revision now requires changes to proceed.Sep 9 2016, 1:36 PM
mart added a comment.Sep 9 2016, 1:43 PM

seems to be ok in android, so good to go when it's made a standalone diff

apol updated this revision to Diff 6659.Sep 12 2016, 1:21 PM
apol edited edge metadata.
  • Fix warnings
mart accepted this revision.Sep 12 2016, 1:23 PM
mart edited edge metadata.
This revision is now accepted and ready to land.Sep 12 2016, 1:23 PM
Closed by commit R169:616af4327cc6: Standardize Drawer width (authored by apol). · Explain WhySep 12 2016, 1:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/controls/GlobalDrawer.qml (2 lines)

Diff 6660

View Options

src/controls/GlobalDrawer.qml

Loading...