Differential D26910

Bugfix for fitsview, checking wrong width & height in initDisplayImage
ClosedPublic
Actions

Authored by murveit on Jan 25 2020, 1:15 AM.

Details

Reviewers
mutlaqja
Commits
R321:5348a5fc91fe: Bugfix for fitsview, checking wrong width & height in initDisplayImage
Summary

The check was for the image width & height, but the image can be downsampled in display.
Should check the downsampled widths and heights.

Test Plan

With this bug, the stretch preview was shown 1/4 size. With the bug-fix it should be back to full size.

Diff Detail

Repository
R321 KStars
Branch
fitsview-buffer-bug (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21649
Build 21667: arc lint + arc unit
murveit created this revision.Jan 25 2020, 1:15 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptJan 25 2020, 1:15 AM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
murveit requested review of this revision.Jan 25 2020, 1:15 AM
mutlaqja accepted this revision.Jan 25 2020, 6:04 AM
This revision is now accepted and ready to land.Jan 25 2020, 6:04 AM
Closed by commit R321:5348a5fc91fe: Bugfix for fitsview, checking wrong width & height in initDisplayImage (authored by murveit, committed by mutlaqja). · Explain WhyJan 25 2020, 6:05 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkstars/fitsviewer/fitsview.cpp (13 lines)

Diff 74344

View Options

kstars/fitsviewer/fitsview.cpp

Loading...