Differential D26902

Fix systemsettings5 crash if kscreenlocker shortcut is empty
AbandonedPublic
Actions

Authored by ahmadsamir on Jan 24 2020, 7:11 PM.

Details

Reviewers
davidedmundson
mart
Group Reviewers
Plasma
Test Plan
  • Make the kscreenlocker shortcut empty
  • Try opening systemsettings -> workspace behaviour, it crashes
  • Apply diff and try again

Diff Detail

Repository
R133 KScreenLocker
Branch
l-crash (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21635
Build 21653: arc lint + arc unit
ahmadsamir created this revision.Jan 24 2020, 7:11 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 24 2020, 7:11 PM
ahmadsamir requested review of this revision.Jan 24 2020, 7:11 PM
ngraham added a subscriber: ngraham.Jan 24 2020, 7:24 PM

Wasn't this already fixed with D26772?

ngraham added a comment.Jan 24 2020, 7:25 PM

Ah, looks like it landed on the stable branch but was never merged to master. Just did that.

Revision Contents
Changeset List

PathPackages
Mkscreensaversettings.cpp (7 lines)

Diff 74328

View Options

kscreensaversettings.cpp

Loading...