[Folder View] Fix text label color in pop-up
ClosedPublic

Authored by ngraham on Thu, Jan 23, 8:31 PM.

Details

Summary

Currently there's a top-level ColorScope that is almost entirely unused except for
introducing a bug whereby the label text in the pop-up is the wrong color. Removing the
ColorScope fixes the bug and does not change the appearance of anything else anywhere else.

BUG: 416658
FIXED-IN: 5.18.0

Test Plan

Hover over a folder and click on button to open a folder pop-up
See that the text color is correct now:

Use Folder view as a containment, as a widget, and in a panel
See that text color is fine everywhere

Use a bunch of different color schemes and repeat the above tests and see that everything
still looks good

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Thu, Jan 23, 8:31 PM
Restricted Application added a project: Plasma. · View Herald TranscriptThu, Jan 23, 8:31 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Thu, Jan 23, 8:31 PM
mart accepted this revision.Thu, Jan 30, 3:40 PM
This revision is now accepted and ready to land.Thu, Jan 30, 3:40 PM
This revision was automatically updated to reflect the committed changes.