Differential D26878

Add missing renamed event when a destination file already existed
ClosedPublic
Actions

Authored by meven on Jan 23 2020, 4:30 PM.

Details

Reviewers
ervin
dfaure
Group Reviewers
Frameworks
Commits
R241:fe5913b1346a: Add missing renamed event when a destination file already existed
Summary

This was missing when a file was being copied/moved, its destination existed, and the user chose to rename the destination file or autorename was set.

Test Plan

ctest -R kiocore-jobtest

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
meven created this revision.Jan 23 2020, 4:30 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 23 2020, 4:30 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
meven requested review of this revision.Jan 23 2020, 4:30 PM
dfaure accepted this revision.Jan 23 2020, 9:45 PM

Nitpicks: make oldDest const; extend jobtest. But this can also go in as is.

This revision is now accepted and ready to land.Jan 23 2020, 9:45 PM
meven retitled this revision from Add a missing renamed event when a destination file already existed to Add missing renamed event when a destination file already existed.Jan 24 2020, 1:42 PM
meven edited the summary of this revision. (Show Details)
meven retitled this revision from Add missing renamed event when a destination file already existed to Add missing renamed events when a destination file already existed.Jan 24 2020, 1:48 PM
meven updated this revision to Diff 74310.Jan 24 2020, 1:49 PM
meven retitled this revision from Add missing renamed events when a destination file already existed to Add missing renamed event when a destination file already existed.

Add tests, add renamed events when autorename was selected, handle another case

meven updated this revision to Diff 74311.Jan 24 2020, 1:50 PM

Avoid touching a line

meven edited the test plan for this revision. (Show Details)Jan 24 2020, 1:50 PM
meven updated this revision to Diff 74316.Jan 24 2020, 4:09 PM

Remove a bad unused

dfaure accepted this revision.Jan 24 2020, 5:51 PM

Nice work! Thanks for the unittest extension.

autotests/jobtest.cpp
1731

Please clean up before committing

1740

QVERIFY(...)

1741

QVERIFY(...)

meven updated this revision to Diff 74324.Jan 24 2020, 6:23 PM
meven marked 3 inline comments as done.

Clean up + QVERIFY

Closed by commit R241:fe5913b1346a: Add missing renamed event when a destination file already existed (authored by meven). · Explain WhyJan 24 2020, 6:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 74325

View Options

autotests/jobtest.h

Loading...
View Options

autotests/jobtest.cpp

Loading...
View Options

autotests/kiotesthelper.h

Loading...
View Options

src/core/copyjob.cpp

Loading...