New class: KConfigTypeInformation
Needs ReviewPublic

Authored by tcanabrava on Jan 23 2020, 12:31 PM.

Details

Reviewers
ervin
dfaure
Summary

This class handles transformations and queries for xml types to
cpp types.

Use KConfigTypeInformation to get the cppType, type and defaultValue

Test Plan

Run unittests, all pass.

Diff Detail

Repository
R237 KConfig
Branch
rewrite_maps
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21572
Build 21590: arc lint + arc unit
tcanabrava created this revision.Jan 23 2020, 12:31 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 23 2020, 12:31 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
tcanabrava requested review of this revision.Jan 23 2020, 12:31 PM
tcanabrava updated this revision to Diff 74231.Jan 23 2020, 1:51 PM
  • Fix position of reference on parameter
ervin added a comment.Jan 28 2020, 6:10 PM

Not sure if we want it in this patch or later on, but wouldn't it be better to have Param::type and CfgEntry::type be of KConfigTypeInformation type? We would then convert early and avoid all those ctor calls to KConfigTypeInformation spread in the code. I suspect it'd improve readability.