Differential D26851

Use cmake's FindBacktrace module to find backtrace(3)
ClosedPublic
Actions

Authored by tcberner on Jan 22 2020, 7:48 PM.

Details

Reviewers
pino
bcooksley
yurchor
Group Reviewers
FreeBSD
Commits
R220:7643e8e552ab: Use cmake's FindBacktrace module to find backtrace(3)
R220:1c9616717037: Use cmake's FindBacktrace module to find backtrace(3)
Summary

Add Backtrace_LIBRARY to the linked libraries, and
Backtrace_INCLUDE_DIRS to the header directories.

This should fix the builds on FreeBSD

Diff Detail

Repository
R220 Subversion Client (KDE SVN)
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21528
Build 21546: arc lint + arc unit
tcberner requested review of this revision.Jan 22 2020, 7:48 PM
tcberner created this revision.
tcberner edited the summary of this revision. (Show Details)Jan 22 2020, 7:50 PM
yurchor added a comment.Jan 22 2020, 7:54 PM

Typo in the commit message: LIBRAIRES-> LIBRARIES

Thanks in advance for fixing it.

tcberner updated this revision to Diff 74167.Jan 22 2020, 7:58 PM
tcberner edited the summary of this revision. (Show Details)

Update commit message

yurchor added a comment.Jan 22 2020, 8:18 PM

+1 Does not break compilation on Linux.

bcooksley accepted this revision.Jan 24 2020, 8:59 AM

Change looks good to me.

This revision is now accepted and ready to land.Jan 24 2020, 8:59 AM
Closed by commit R220:7643e8e552ab: Use cmake's FindBacktrace module to find backtrace(3) (authored by tcberner). · Explain WhyJan 24 2020, 5:09 PM
This revision was automatically updated to reflect the committed changes.
jjazeix added a subscriber: jjazeix.May 3 2020, 10:43 AM

Hi,

I cherry-picked it on the stable branch (2.1) too to fix the build (https://build.kde.org/view/Failing/job/Extragear/job/kdesvn/job/stable-kf5-qt5%20FreeBSDQt5.14/).

Thanks

Revision Contents
Changeset List

Diff 74165

View Options

src/svnqt/CMakeLists.txt

Loading...
View Options

src/svnqt/cmake/FindSubversion.cmake

Loading...