Fix crash in variable expansion (used by external tools)
ClosedPublic

Authored by dhaumann on Jan 21 2020, 5:13 PM.

Details

Summary

findClosing() is already called with +2 to account for the
starting %{ characters. So we start at the given pos and
increment it only after the while loop. Unbalanced cases
of '{' and '}' are now also unit tested.

Test Plan

make && make test

Diff Detail

Repository
R39 KTextEditor
Branch
fix-variable-expansion
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21448
Build 21466: arc lint + arc unit
dhaumann created this revision.Jan 21 2020, 5:13 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptJan 21 2020, 5:13 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
dhaumann requested review of this revision.Jan 21 2020, 5:13 PM
cullmann accepted this revision.Jan 21 2020, 5:28 PM
This revision is now accepted and ready to land.Jan 21 2020, 5:28 PM
This revision was automatically updated to reflect the committed changes.