Differential D268

Start plasma-settings maximized by default
AbandonedPublic
Actions

Authored by bshah on Aug 25 2015, 6:12 AM.

Details

Reviewers
sebas
Summary

On horizontal form factor it is desired to have a full window opened instead of tiny mobile sized window.

Diff Detail

Repository
R21 Plasma Settings
Lint
Lint Skipped
Unit
Unit Tests Skipped
bshah updated this revision to Diff 603.Aug 25 2015, 6:12 AM
bshah retitled this revision from to Start plasma-settings maximized by default.
bshah updated this object.
bshah edited the test plan for this revision. (Show Details)
bshah added a reviewer: sebas.
bshah set the repository for this revision to R21 Plasma Settings.
bshah added a project: Plasma: Mobile.
graesslin added a subscriber: graesslin.Aug 25 2015, 6:15 AM

Why is that needed? We have KWin configured to use the maximized positioning strategy.

bshah added a comment.Aug 25 2015, 6:22 AM
In D268#4770, @graesslin wrote:

Why is that needed? We have KWin configured to use the maximized positioning strategy.

Okay I was missing that kwinrc from plasma-phone-settings but still IMO it should be handled independent of kwin, no?

graesslin added a comment.Aug 25 2015, 6:42 AM
In D268#4771, @bshah wrote:
In D268#4770, @graesslin wrote:

Why is that needed? We have KWin configured to use the maximized positioning strategy.

Okay I was missing that kwinrc from plasma-phone-settings but still IMO it should be handled independent of kwin, no?

If I start it on my FullHD screen for testing I certainly do not want to have it started as maximized. That would be highly annoying.

Given that for fullscreen there is a config option, I suggest to make maximized also a config option.

bshah added a comment.Aug 25 2015, 6:46 AM

Okay, closing this revision

bshah abandoned this revision.Aug 25 2015, 6:50 AM
sebas edited edge metadata.Aug 31 2015, 11:59 AM

I'd actually prefer doing this via a commandline switch or a kwin script. Otherwise, it's unnecessarily hard to start plasma-settings non-maximized.

Easiest is probably to just add -f to the .desktop file's Exec line.

Revision Contents
Changeset List

PathPackages
Msrc/main.cpp (2 lines)

Diff 603

View Options

src/main.cpp

Loading...