The affected files have been reformatted following the KDE coding style (this makes up most of the changes).
kcm.cpp: The config.setFirstRun method calls have been simplified (line 103) and the defaultFolders function is now inline.
filterfoldermodel.cpp: Use const references for the mount points (folderDisplayName method, line 204), simplify if statement in shouldShowMountPoint (line 223) and remove unnecessary return in data method.
Details
Details
- Reviewers
ngraham meven davidedmundson
Should work as before
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 21420 Build 21438: arc lint + arc unit
| kcms/baloo/filteredfoldermodel.cpp | ||
|---|---|---|
| 38 | I am not sure too, because in the plasma-workspace project and even some qt files it is sometimes formatted like above but sometimes it is indented. | |
| kcms/baloo/kcm.cpp | ||
| 72 | Now it should fit the policy. KDE does not specify their own style for lambdas but uses the one of Qt: https://wiki.qt.io/Coding_Conventions . | |
Comment Actions
emit and Q_EMIT are the same thing, I wouldn't change any future instances
Q_EMIT has the advantage of not conflicting with some other libraries like emit sometimes can
Comment Actions
Abandoning this, because there have been a few patches to the same kcm and this is mostly formatting.