[Task Manager] Disallow adding/removing launchers when system immutable
ClosedPublic
Actions

Authored by broulik on Sep 6 2016, 10:25 AM.

Details

Reviewers

mart

Group Reviewers

Plasma

Commits

Summary

We locked favorites in Kickoff but didn't lock down the launchers.

Test Plan

Put the following in kdeglobals

[KDE Action Restrictions]
plasma/plasmashell/unlockedDesktop=false

"Show launcher when not running" and "Remove this launcher" entry was gone from context menu
Dropping app on task bar did nothing
"Add as launcher" in Kickoff was hidden already in this case

Without the aforementioned restriction:

"Show launcher when not running" and "Remove this launcher" entry was shown in context menu
Dropping app on task bar added launcher
"Add as launcher" in Kickoff added launcher

Repository

R119 Plasma Desktop

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

broulik retitled this revision from to [Task Manager] Disallow adding/removing launchers when system immutable.

broulik updated this object.

broulik edited the test plan for this revision. (Show Details)

broulik added a reviewer: Plasma.

broulik set the repository for this revision to R119 Plasma Desktop.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

mart added a reviewer: mart.

This revision is now accepted and ready to land.Sep 6 2016, 11:31 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			applets/taskmanager/package/contents/ui/ContextMenu.qml (4 lines)
M			applets/taskmanager/package/contents/ui/main.qml (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	6478			Sep 6 2016, 10:22 AM	★	★
Diff 2	6484	cb47729	rPLASMADESKTOP9c8b7b7e9aa3d319415d6be1a25367c06395a109	Sep 6 2016, 1:27 PM	★	★