Proper clean commits can be seen in https://github.com/TheOneRing/knotifications/commits/rhichtext
Details
Details
Diff Detail
Diff Detail
- Repository
- R289 KNotifications
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 21333 Build 21351: arc lint + arc unit
Comment Actions
We have the same problem on Linux (if the server doesn't support rich text) and probably Android too. In notifybypopup we do this with QXmlStreamReader + some API from KCodecs, but your solution is much simpler and nicer.
Ideally this should be done in KNotification instead of the backends. Therefore we'd need some API in KNotificationPlugin/KNotification to indicate whether rich text is supported. The KNotificationManager code is quite convoluted currently, but it should be doable.
This would help our quest of making KNotifications Tier 1 ;-)
Comment Actions
And here in clean with proper commits https://github.com/TheOneRing/knotifications/tree/rhichtext