Buttons colored with special text role colors as backgrounds don't always look nice with black text on light themes. They should have been using background role colors for the background, but the background role colors they needed weren't available. This patch adds the missing background role colors.
Details
Details
- Reviewers
mart - Group Reviewers
Kirigami Plasma - Commits
- R169:ec44c3880b60: Add active, link, visited, negative, neutral and positive background colors
Diff Detail
Diff Detail
- Repository
- R169 Kirigami
- Branch
- more-background-colors (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 21305 Build 21323: arc lint + arc unit
Comment Actions
This is ok, but is missing a piece.
this should be reflected also in
qqc2-desktop-style/kirigami-plasmadesktop-integration/plasmadeksotptheme.cpp or it won't actually follow the configured color scheme.
in that file, look for all instances talking about PositiveTextColor, and add the missing colors from there pretty much copying what's already in