Differential D26745

Add active, link, visited, negative, neutral and positive background colors
ClosedPublic
Actions

Authored by ndavis on Jan 18 2020, 2:37 AM.

Details

Reviewers
mart
Group Reviewers
Plasma
Kirigami
Commits
R858:ae9c5c088800: Add active, link, visited, negative, neutral and positive background colors
Summary

Buttons colored with special text role colors as backgrounds don't always look nice with black text on light themes. They should have been using background role colors for the background, but the background role colors they needed weren't available. This patch adds the missing background role colors.

Diff Detail

Repository
R858 Qt Quick Controls 2: Desktop Style
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ndavis created this revision.Jan 18 2020, 2:37 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 18 2020, 2:37 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ndavis requested review of this revision.Jan 18 2020, 2:37 AM
mart accepted this revision.Jan 20 2020, 9:55 AM
This revision is now accepted and ready to land.Jan 20 2020, 9:55 AM
Closed by commit R858:ae9c5c088800: Add active, link, visited, negative, neutral and positive background colors (authored by ndavis). · Explain WhyJan 20 2020, 3:58 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 73956

View Options

kirigami-plasmadesktop-integration/plasmadesktoptheme.cpp

Loading...