[Components 3]Make slider tickmarks optional

Authored by gvgeo on Jan 17 2020, 7:31 PM.


Group Reviewers

Add tickmarksEnabled variable.

Test Plan

Test with tickmarksEnabled: false

Diff Detail

R242 Plasma Framework (Library)
slider (branched from master)
No Linters Available
No Unit Test Coverage
Build Status
Buildable 21290
Build 21308: arc lint + arc unit
gvgeo created this revision.Jan 17 2020, 7:31 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 17 2020, 7:31 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
gvgeo requested review of this revision.Jan 17 2020, 7:31 PM
gvgeo added a comment.EditedJan 17 2020, 7:33 PM

Added to disable tickmarks, in battery's keyboard brightness control. (Related patch not ready yet)

gvgeo retitled this revision from [Components 3]Make Slider tickmarks optional to [Components 3]Make slider tickmarks optional.Jan 17 2020, 7:39 PM

We've previously avoided adding any API to PC3 so it can be used as a Qqc2-style.

Is there a way to achieve this with the existing qqc2 API?

apol added a subscriber: apol.Jan 17 2020, 11:42 PM

You should only see them if you have very a few discrete number of steps. Can you show a screenshot of what you see that you don't like?

gvgeo added a comment.EditedJan 18 2020, 5:02 AM

My case would be solved with stepCount > 1. But AFAIK there are keyboards with 3-4 steps.

Is there a way to achieve this with the existing qqc2 API?

Not that I know. And need moved signal from it.

edit: With recent change to Components 3, Need 33.3 rotations to change from minimum to maximum brightness. I mention this because in qquickslider.cpp step comes from stepSize without limiting the amount, as in qqc1.

apol added a comment.EditedJan 19 2020, 11:16 PM

But this means that for your keyboard it's either on or off, right?

This is what it looks for me. The screen has hundreds of steps so it shows nothing, for the keyboard it has a middle step so it's shown below. I don't think it should be removed.

Maybe the weird bit from your system is that it should be a checkbox for you?

gvgeo abandoned this revision.Jan 20 2020, 8:13 AM

Closing, when there are few steps, should be marked.

...should be a checkbox for you?

That's good idea.
I 'll try to add a checkbox when a keyboard is on/off only.
Not sure how it would look.