Differential D26727

Fix font bug in ProgressBox
ClosedPublic
Actions

Authored by shubham on Jan 17 2020, 1:26 PM.

Details

Reviewers
sandsmark
ngraham
Commits
R352:b190c6da411c: Fix font bug in ProgressBox
Summary

BUG: 391296

Instead of using system's default font, it was using the best suited font which was matching with system's look and feel.

Test Plan

Before:


After:

Diff Detail

Repository
R352 Filelight
Branch
font
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21270
Build 21288: arc lint + arc unit
shubham created this revision.Jan 17 2020, 1:26 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald TranscriptJan 17 2020, 1:26 PM
shubham requested review of this revision.Jan 17 2020, 1:26 PM
shubham edited the summary of this revision. (Show Details)Jan 17 2020, 1:30 PM
ngraham added a comment.Jan 17 2020, 1:31 PM

Please always add screenshots for patches that result in UI changes.

src/progressBox.cpp
33

If indeed we no longer need to call QGuiApplication::font(), then we can get rid of this line too

34

Moving #include <QPainter> is unrelated

47

Do we even need this at all anymore? Can we just remove it?

shubham updated this revision to Diff 73765.Jan 17 2020, 1:38 PM

Fix unrelated changes

shubham marked 3 inline comments as done.Jan 17 2020, 1:38 PM
shubham edited the test plan for this revision. (Show Details)
In D26727#595976, @ngraham wrote:

Please always add screenshots for patches that result in UI changes.

Was in process of capturing those, but you were too quick ; )

ngraham accepted this revision.Jan 17 2020, 1:45 PM

LGTM but please wait for confirmation from @sandsmark

This revision is now accepted and ready to land.Jan 17 2020, 1:45 PM
shubham added a comment.Mar 23 2020, 8:37 AM

@ngraham Looks like this change is going unnoticed. Can I go ahead pushing it?

sandsmark accepted this revision.Mar 28 2020, 12:17 PM
shubham updated this revision to Diff 78729.Mar 28 2020, 2:30 PM

Rebase on master

Closed by commit R352:b190c6da411c: Fix font bug in ProgressBox (authored by shubham). · Explain WhyMar 28 2020, 2:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/progressBox.cpp (5 lines)

Diff 73763

View Options

src/progressBox.cpp

Loading...