Differential D26716

[wayland] Provide correct input geometry for client-side decorated clients
ClosedPublic
Actions

Authored by zzag on Jan 16 2020, 8:33 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:72ca9268cef8: [wayland] Provide correct input geometry for client-side decorated clients
Summary

Currently, the input geometry for client-side decorated clients matches
the frame geometry, which makes it impossible for a user to resize such
clients by just dragging invisible area near window borders.

BUG: 416346

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Jan 16 2020, 8:33 PM
Restricted Application added a project: KWin. · View Herald TranscriptJan 16 2020, 8:33 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Jan 16 2020, 8:33 PM
ngraham added a subscriber: ngraham.Jan 19 2020, 3:00 AM

Good candidate for the 5.18 branch.

cblack added a subscriber: cblack.EditedJan 19 2020, 3:15 AM

I can't tell if this is GTK or KWin's fault, but surface resizing with CSDs is a bit wonky with this patch.

At least it exists, which is better than where it was before.

zzag added a comment.EditedJan 20 2020, 12:47 AM
In D26716#596682, @cblack wrote:

I can't tell if this is GTK or KWin's fault, but surface resizing with CSDs is a bit wonky with this patch.

At least it exists, which is better than where it was before.

Huh, I am aware of a similar issue but it is related to the minimum and the maximum specified window size (which I'm working on). Just to be sure, can you build KWin without this patch and check whether you're still able to reproduce these resizing issues? In order to resize a window, press Alt + RMB and move the mouse around.

cblack added a comment.Jan 20 2020, 2:25 AM
In D26716#597173, @zzag wrote:
In D26716#596682, @cblack wrote:

I can't tell if this is GTK or KWin's fault, but surface resizing with CSDs is a bit wonky with this patch.

At least it exists, which is better than where it was before.

Huh, I am aware of a similar issue but it is related to the minimum and the maximum specified window size (which I'm working on). Just to be sure, can you build KWin without this patch and check whether you're still able to reproduce these resizing issues? In order to resize a window, press Alt + RMB and move the mouse around.

The window position remains constant when resizing the window without this patch and using the resize option in the alt-f3 menu.

zzag added a comment.Jan 20 2020, 8:47 AM
In D26716#596682, @cblack wrote:

I can't tell if this is GTK or KWin's fault, but surface resizing with CSDs is a bit wonky with this patch.

Does this happen with only one particular client or with all of them?

zzag added a comment.Jan 20 2020, 8:51 AM

Also, what version of KWayland do you have on your system?

zzag added a comment.Jan 22 2020, 10:10 AM

@cblack Can you cherry-pick this patch on top of D26831 and check whether there are still issues with resizing client-side decorated clients?

davidedmundson accepted this revision.Jan 23 2020, 10:22 PM
This revision is now accepted and ready to land.Jan 23 2020, 10:22 PM
Closed by commit R108:72ca9268cef8: [wayland] Provide correct input geometry for client-side decorated clients (authored by zzag). · Explain WhyJan 23 2020, 11:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Minput.cpp (4 lines)
Mxdgshellclient.h (1 line)
Mxdgshellclient.cpp (9 lines)

Diff 74283

View Options

input.cpp

Loading...
View Options

xdgshellclient.h

Loading...
View Options

xdgshellclient.cpp

Loading...