This fixes the bug I introduced when I fixed 414442 in the wrong way, makes the UI more
recular, removes a QQC1 dep, and makes the view fully keyboard-navigeable.
BUG: 414442
FIXED-IN: 5.18.0
broulik |
VDG | |
Plasma |
This fixes the bug I introduced when I fixed 414442 in the wrong way, makes the UI more
recular, removes a QQC1 dep, and makes the view fully keyboard-navigeable.
BUG: 414442
FIXED-IN: 5.18.0
No Linters Available |
No Unit Test Coverage |
Buildable 21540 | |
Build 21558: arc lint + arc unit |
When I tested this, there was a very noticable delay (~10s) between starting the search and items appearing, so the busy indicator is IMO necessary.
applets/weather/package/contents/ui/config/WeatherStationPicker.qml | ||
---|---|---|
43–44 | Given the item is hidden anyway, you can probably assign this as a binding right away | |
135 | Does focus: true on the TextField instead of the ListView make this redundant? | |
144 | This is unlike any other list we have in settings? | |
167 | You're constantly breaking this binding by assigning to it elsewhere programmatically. |
applets/weather/package/contents/ui/config/WeatherStationPicker.qml | ||
---|---|---|
144 | I copied it from the notifications KCM :) |
Using Kirigami.SearchField would be nice, so Ctrl+F acts as a shortcut for getting back to the search field when focus jumped to the list.
(And can we later improve that weird workflow where no providers are selected and the Search field is disabled for no immediately obvious reason? :)
applets/weather/package/contents/ui/config/WeatherStationPicker.qml | ||
---|---|---|
41 | You no longer hide the noSearchResultsReport label when a new query starts, awkwardly overlapping the busy indicator until the new one completes. | |
94 | Maybe explicitly focus this it when the dialog opens again otherwise on subsequent opening of the dialog it will instead have whatever item was focused previously? | |
144 | The notifications KCM doesn't wrap, though? | |
146 | Unused id | |
166 | This should be set programatically when the query finishes like before instead of a binding. Otherwise you'll end up in the weird situation where it says "Nothing found for foo" and then you start typing a new query and it live updates to "Nothing found for bar" even though you didn't actually launch a new query |