[kstyle] Drop Qt 4 style plugin
AcceptedPublic

Authored by zzag on Mon, Jan 13, 11:40 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Maniphest Tasks
T12496: Shadows API in KWindowSystem
Summary

KWindowSystem cannot be used in the Qt 4 style plugin. On the other hand,
we need to use KWindowSystem to make QWidget-based internal clients in
KWin cast drop-shadows.

Another problem with the Qt 4 style plugin is that some distributions
have already dropped Qt 4 (it's been EOL for almost 5 years), so one has
to build it in order to verify that his or her change works with Qt 4.

Given maintenance burden and the fact that Qt 6 is around the corner,
this change drops the Qt 4 style plugin.

Diff Detail

Repository
R113 Oxygen Theme
Branch
port-to-shadows-api
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21039
Build 21057: arc lint + arc unit
zzag created this revision.Mon, Jan 13, 11:40 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMon, Jan 13, 11:40 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
zzag requested review of this revision.Mon, Jan 13, 11:40 AM
zzag edited the summary of this revision. (Show Details)Mon, Jan 13, 11:47 AM
davidedmundson accepted this revision.Mon, Jan 13, 4:50 PM
davidedmundson added a subscriber: davidedmundson.

Seems we got the go-ahead from kde-distro-packagers ML so ++

After 5.18 forks please

This revision is now accepted and ready to land.Mon, Jan 13, 4:50 PM