[kstyle] Port to KWindowSystem shadows API
Needs ReviewPublic

Authored by zzag on Sun, Jan 12, 6:55 PM.

Details

Reviewers
None
Group Reviewers
KWin
Plasma
Maniphest Tasks
T12496: Shadows API in KWindowSystem

Diff Detail

Repository
R113 Oxygen Theme
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21198
Build 21216: arc lint + arc unit
zzag created this revision.Sun, Jan 12, 6:55 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSun, Jan 12, 6:55 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
zzag requested review of this revision.Sun, Jan 12, 6:55 PM
davidedmundson added inline comments.
kstyle/oxygenshadowhelper.cpp
291–292

I don't understand what this line is trying to do

zzag updated this revision to Diff 73644.Wed, Jan 15, 6:38 PM
  • Drop sub-surface check
  • Don't use obsolete QWidget::isTopLevel()
zzag marked an inline comment as done.Wed, Jan 15, 6:40 PM
zzag added inline comments.
kstyle/oxygenshadowhelper.cpp
291–292

I presume that it acted as a sub-surface test, in either case we don't need it.