Remove fallback to KPassivePopup
Needs ReviewPublic

Authored by nicolasfella on Sun, Jan 12, 4:11 PM.

Details

Reviewers
broulik
Group Reviewers
Frameworks
Summary

KNotifications has proper support for all major platforms (freedesktop, windows, macOS, Android). The KPassivePopup fallback is only relevant for Linux when no FDO notification daemon is running. D26604 addresses the corner case of a crashing notification daemon. IMO the case of the user having no notification daemon at all is not worth supporting since the users intention is verly clearly to not have notifications.

This allows to drop a good amount of code. It reduces the dependency on Widgets so we can eventually get rid of it which is nice for Android. Furthermore the reduced complexity will make it easier to implement our plans for KF6

Test Plan

Still get regular notifications

Depends on D26604

Diff Detail

Repository
R289 KNotifications
Branch
nofallback
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21006
Build 21024: arc lint + arc unit
nicolasfella created this revision.Sun, Jan 12, 4:11 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSun, Jan 12, 4:11 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
nicolasfella requested review of this revision.Sun, Jan 12, 4:11 PM