Differential D2660

Prefer an algorithm over an explicit for loop
ClosedPublic
Actions

Authored by jkt on Sep 4 2016, 11:40 PM.

Details

Reviewers
davidedmundson
broulik
Commits
R122:d492dc57eeb3: Prefer an algorithm over an explicit for loop

Diff Detail

Repository
R122 Powerdevil
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jkt updated this revision to Diff 6435.Sep 4 2016, 11:40 PM
jkt retitled this revision from to Prefer an algorithm over an explicit for loop.
jkt updated this object.
jkt edited the test plan for this revision. (Show Details)
jkt added a reviewer: broulik.
jkt set the repository for this revision to R122 Powerdevil.
Restricted Application added a project: Plasma. · View Herald TranscriptSep 4 2016, 11:40 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart added a subscriber: mart.Oct 6 2016, 9:04 AM

any news on that?

davidedmundson accepted this revision.Oct 6 2016, 10:16 AM
davidedmundson added a reviewer: davidedmundson.
davidedmundson added a subscriber: davidedmundson.

you can make them constBegin() now you're doing the clear after?

This revision is now accepted and ready to land.Oct 6 2016, 10:16 AM
jkt updated this revision to Diff 7144.Oct 6 2016, 11:14 AM
jkt edited edge metadata.
jkt removed R122 Powerdevil as the repository for this revision.

I used cbegin because this is in a place which uses STL idioms.

Closed by commit R122:d492dc57eeb3: Prefer an algorithm over an explicit for loop (authored by jkt, committed by davidedmundson). · Explain WhyNov 15 2017, 3:42 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mdaemon/powerdevilcore.cpp (9 lines)

Diff 22397

View Options

daemon/powerdevilcore.cpp

Loading...