[Applet]Hide hamburger menu when empty
AcceptedPublic

Authored by gvgeo on Fri, Jan 10, 10:25 PM.

Details

Reviewers
drosca
ngraham
Group Reviewers
VDG
Plasma
Summary

Don't show devices/applications hamburger menu when there are no options.
Hide "Record/Play all audio via this device" if there is only 1 device.
Prevent unavailable ports be active.

Last is a workaround to prevent locking a device to an unavailable port.
This can happen cause of the lack of a call from pulseaudio for a port
availability change.

Depends on D26418

Test Plan

Lock can happen when an unused and available port becomes unavailable.
Until data refresh, a user can select the unavailable port. After the
switch if there is only 1 available port, UI will hide port selection,
locking user to an unavailable port.

2 vs 1 output devices

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Branch
ports (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20931
Build 20949: arc lint + arc unit
gvgeo created this revision.Fri, Jan 10, 10:25 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFri, Jan 10, 10:25 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
gvgeo requested review of this revision.Fri, Jan 10, 10:25 PM
gvgeo edited the summary of this revision. (Show Details)Fri, Jan 10, 10:28 PM
gvgeo edited the test plan for this revision. (Show Details)
gvgeo added a comment.EditedFri, Jan 10, 10:38 PM

KCM is in a state of confusion. Doesn't see the port change from lock prevention, and shows the port that was selected(unavailable). While the volume and mute affect the active port.
If these patches ever get accepted(edit.my doubts are about code acceptance), can see at a later time this part.

gvgeo edited the test plan for this revision. (Show Details)Fri, Jan 10, 10:39 PM
ngraham accepted this revision.Fri, Jan 10, 11:17 PM
ngraham added a subscriber: ngraham.

Nice.

This revision is now accepted and ready to land.Fri, Jan 10, 11:17 PM