default button state
AbandonedPublic
Actions

Authored by bport on Jan 8 2020, 2:56 PM.

Details

Reviewers

Repository

R119 Plasma Desktop

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 20805
Build 20823: arc lint + arc unit

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

bport requested review of this revision.Jan 8 2020, 2:56 PM

kcms/kded/kcmkded.cpp
319	I know you didn't write that line, but it looks like this contradicts the code in save() or I'm confused? (the code is not easy) It looks like save ignore the state of the checkbox if X-KDE-Kded-autoload is false in the plugin metadata.

Wait this code review is merged and will port it to KConfigXT
https://phabricator.kde.org/D26506

bport abandoned this revision.Jan 8 2020, 4:32 PM

			Path	Packages
M			kcms/kded/kcmkded.h (7 lines)
M			kcms/kded/kcmkded.cpp (40 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	73068	db1ebdc		Jan 8 2020, 2:56 PM	★	★