Differential D26492

[KOpenWithDialog] Hide collapsible group box when all options inside are hidden
ClosedPublic
Actions

Authored by broulik on Jan 7 2020, 12:50 PM.

Details

Reviewers
ngraham
Group Reviewers
Frameworks
Commits
R241:1e7a62c98f8a: [KOpenWithDialog] Hide collapsible group box when all options inside are hidden
Summary

BUG: 415510

Test Plan
  • Normal case still has box
  • Ran with hideRunInTerminal and box was gone

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jan 7 2020, 12:50 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 7 2020, 12:50 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Jan 7 2020, 12:50 PM
broulik updated this revision to Diff 72971.
  • Simplify
broulik updated this revision to Diff 72972.Jan 7 2020, 12:53 PM
  • Turns out no close on exit doesnt imply the other, old code was correcter L:)
ngraham accepted this revision.Jan 7 2020, 2:53 PM
This revision is now accepted and ready to land.Jan 7 2020, 2:53 PM
ahmadsamir added a subscriber: ahmadsamir.Jan 7 2020, 4:17 PM

Hello.
Bug 415951 doesn't look related to this diff.

broulik edited the summary of this revision. (Show Details)Jan 7 2020, 10:14 PM
Closed by commit R241:1e7a62c98f8a: [KOpenWithDialog] Hide collapsible group box when all options inside are hidden (authored by broulik). · Explain WhyJan 13 2020, 12:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/widgets/kopenwithdialog.cpp (5 lines)

Diff 73394

View Options

src/widgets/kopenwithdialog.cpp

Loading...