Differential D26444

[RunnerResultsModel] Watch krunnerrc and reparse configuration when it changed
Needs RevisionPublic
Actions

Authored by broulik on Jan 5 2020, 8:10 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Summary

This was present in the old SourcesModel but not ported to the new one.

Test Plan

5.17
Noticed that changing runner settings didn't update krunner live.
The KCM still doesn't enable Apply properly but that is separate. When I hit OK things work immediately as expected now.

Diff Detail

Repository
R112 Milou
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Jan 5 2020, 8:10 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 5 2020, 8:10 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jan 5 2020, 8:10 PM
fvogt added a subscriber: fvogt.Jan 7 2020, 8:43 AM
fvogt added inline comments.
lib/runnerresultsmodel.cpp
189

This reloads the configuration in RunnerManager, so why is this done in RunnerResultsModel?

davidedmundson requested changes to this revision.Apr 14 2020, 10:29 AM
davidedmundson added a subscriber: davidedmundson.

krunner also has horrible file watcher.

This either makes sense at a library level (krunner)
or in the frontend (krunner)

but milou somewhere in the middle seems weird.

This revision now requires changes to proceed.Apr 14 2020, 10:29 AM

Revision Contents
Changeset List

PathPackages
Mlib/runnerresultsmodel.h (1 line)
Mlib/runnerresultsmodel.cpp (15 lines)

Diff 72827

View Options

lib/runnerresultsmodel.h

Loading...
View Options

lib/runnerresultsmodel.cpp

Loading...