Differential D29401

[KRunner] Fix watched config file path
ClosedPublic
Actions

Authored by ksmanis on May 4 2020, 10:17 AM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
Summary

The "Clear History" button in the KCM is currently broken, since we are
not watching the actual config file, but a file called "General", i.e.,
the name of the KConfigGroup. Therefore, the QML runner is never
informed that the history was erased in the config file.

Test Plan

Clear History now works as expected on master and v5.18.4.1.

Screencast of current behavior:

Screencast of patched behavior:

Diff Detail

Repository
R120 Plasma Workspace
Branch
krunner-fix-watched-config-path (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26309
Build 26327: arc lint + arc unit
ksmanis created this revision.May 4 2020, 10:17 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 4 2020, 10:17 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ksmanis requested review of this revision.May 4 2020, 10:17 AM
ksmanis edited the test plan for this revision. (Show Details)May 4 2020, 10:19 AM
broulik added a subscriber: broulik.May 4 2020, 10:25 AM

That's not the bug I tried to solve in D26444, was it?

ksmanis added a comment.May 4 2020, 10:38 AM

Nope, different bugs, similar solutions. I can still reproduce the other bug (I never noticed it before btw). I am not sure if this patch fixes any other regressions other than the Clear History button in the KCM.

ngraham accepted this revision.May 4 2020, 2:07 PM
ngraham added a subscriber: ngraham.

Good catch! Seems worthy of landing on the stable branch? What do you think, @broulik?

This revision is now accepted and ready to land.May 4 2020, 2:07 PM
broulik added a comment.May 4 2020, 2:09 PM

Ideally, we'd change the KCM to write the key with KConfig::Notify and then use KConfigWatcher here

ngraham added a comment.May 4 2020, 2:10 PM

Maybe we can do that on master and land this on the stable branch?

ksmanis closed this revision.May 4 2020, 3:18 PM

Revision Contents
Changeset List

PathPackages
Mkrunner/view.cpp (4 lines)

Diff 81861

View Options

krunner/view.cpp

Loading...