KDevelop, when using vi input mode, crashes a lot on trying to dereference a null pointer.
Awkwardly this change break the unit test vimode_completion, but I confess I think it should cause no harm.
michalhumpula |
KTextEditor |
KDevelop, when using vi input mode, crashes a lot on trying to dereference a null pointer.
Awkwardly this change break the unit test vimode_completion, but I confess I think it should cause no harm.
Lint Skipped |
Unit Tests Skipped |
Hi Leandro, thanks for the patch. The check for the nullptr should be perfectly ok. It's weird that it breaks the tests. One little nitpick: please try to comply with the code style of kf5 libraries https://techbase.kde.org/Policies/Frameworks_Coding_Style#Braceslibraries.
The tests are passing for me before and after apllying the patch, so please commit to master.
Thanks guys - this is quite likely a fix for https://bugs.kde.org/show_bug.cgi?id=367786
@leandrosantiago Do you already have commit rights, or should we commit this patch for you?
Submitted, thanks for the patch!
cullmann committed rKTEXTEDITORf9f6f2383f3a: Fix constant crashes related to the vi command bar (authored by leandrosantiago).
Fix constant crashes related to the vi command bar
Differential Revision: https://phabricator.kde.org/D2643
BUG: 367786
BRANCHES
master
AFFECTED FILES
/src/vimode/emulatedcommandbar/emulatedcommandbar.cpp
USERS
leandrosantiago (Author)
cullmann (Committer)
COMMIT
https://phabricator.kde.org/rKTEXTEDITORf9f6f2383f3a
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: leandrosantiago, cullmann