Clean up redundant methods for KConfigskeleton already present for base class KCoreConfigSkeleton
Changes PlannedPublic

Authored by meven on Jan 2 2020, 12:37 PM.

Details

Reviewers
ervin
Group Reviewers
Frameworks

Diff Detail

Repository
R265 KConfigWidgets
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20528
Build 20546: arc lint + arc unit
meven created this revision.Jan 2 2020, 12:37 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 2 2020, 12:37 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
meven requested review of this revision.Jan 2 2020, 12:37 PM
meven added a comment.Jan 2 2020, 12:39 PM

The methods are straight copy-paste compared to KCoreConfigSkeleton.
The binary compatiblity might be affected though so we might want to do it for KF6 only.

ervin added a comment.Jan 2 2020, 1:09 PM

Indeed will have to wait KF6 branching AFAICT. Could you add a task for it in the KF6 board in the waiting for branching column? Just to make sure we don't forget it.

meven planned changes to this revision.Jan 2 2020, 1:48 PM

Indeed will have to wait KF6 branching AFAICT. Could you add a task for it in the KF6 board in the waiting for branching column? Just to make sure we don't forget it.

Added a bullet to https://phabricator.kde.org/T12147 and created https://phabricator.kde.org/T12480