Differential D26304

[PageRow] Disable swipe forwards/backwards gesture by default
AbandonedPublic
Actions

Authored by cblack on Dec 30 2019, 8:51 PM.

Details

Reviewers
mart
Group Reviewers
VDG
Kirigami
Summary

The PageRow's ColumnView no longer reacts to a forwards/backwards gesture by default. This removes a major source of overlapping, ambiguous, and otherwise badly designed gestures in Kirigami, i.e. drawer gestures overlapping pagerow gestures, user missing target for gesture and accidentally invoking pagerow gesture, etc.

Test Plan

Before: PageRow reacts to gesture by default. (check with kirigami2gallery)
After: PageRow doesn't react to gesture by default. (check with kirigami2gallery)

Diff Detail

Repository
R169 Kirigami
Branch
remove-pagerow-gesture-by-default (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20422
Build 20440: arc lint + arc unit
cblack created this revision.Dec 30 2019, 8:51 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptDec 30 2019, 8:51 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
cblack requested review of this revision.Dec 30 2019, 8:51 PM
ouwerkerk added a subscriber: ouwerkerk.Dec 31 2019, 4:59 PM

This completely alters one of the core propositions of how a Kirigami UX works. I may be mistaken, but if I understand it correctly drawers are supposed to be accessible via buttons. If gestures conflict, why remove page row navigation by gesture rather than drawer gestures?

ndavis added a subscriber: ndavis.Dec 31 2019, 11:54 PM
In D26304#585525, @ouwerkerk wrote:

This completely alters one of the core propositions of how a Kirigami UX works. I may be mistaken, but if I understand it correctly drawers are supposed to be accessible via buttons. If gestures conflict, why remove page row navigation by gesture rather than drawer gestures?

I agree with this. Page navigation by swiping actually feels very nice while swiping to open a drawer is nice, but not needed (except as a way to keep Kirigami familiar to Android users).

mart requested changes to this revision.Jan 7 2020, 9:04 AM
mart added a subscriber: mart.

no.
I veto this change.

This revision now requires changes to proceed.Jan 7 2020, 9:04 AM
mart added a comment.Jan 7 2020, 9:05 AM

also, on plasma mobile, there is no global back button, and i don't want any back button anywhere in the app

cblack abandoned this revision.Feb 7 2020, 10:04 PM

Revision Contents
Changeset List

PathPackages
Msrc/controls/PageRow.qml (2 lines)

Diff 72420

View Options

src/controls/PageRow.qml

Loading...