Differential D26276

KFilePlaceEditDialog: fix crash when editing the Trash place
ClosedPublic
Actions

Authored by elvisangelaccio on Dec 29 2019, 6:06 PM.

Details

Reviewers
ngraham
Group Reviewers
Frameworks
Commits
R241:a9ea007cf87c: KFilePlaceEditDialog: fix crash when editing the Trash place
Summary

m_iconButton is initialized only when the url scheme of the place being
edited is not trash.

BUG: 415676
FIXED-IN: 5.66

Test Plan

Right-click the Trash place in dolphin and change the name.

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 29 2019, 6:06 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
elvisangelaccio requested review of this revision.Dec 29 2019, 6:06 PM
ngraham accepted this revision.Dec 29 2019, 6:08 PM
ngraham added a subscriber: ngraham.

Oops! Nice fix.

This revision is now accepted and ready to land.Dec 29 2019, 6:08 PM
Closed by commit R241:a9ea007cf87c: KFilePlaceEditDialog: fix crash when editing the Trash place (authored by elvisangelaccio). · Explain WhyDec 29 2019, 6:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 72340

View Options

src/filewidgets/kfileplaceeditdialog.cpp

Loading...