Set the restore geometry after placing a ShellClient for the first time
ClosedPublic
Actions

Authored by graesslin on Aug 30 2016, 11:20 AM.

Details

Reviewers

luebking
bshah

Group Reviewers

Plasma on Wayland
KWin

Commits

R108:d3741bd530cd: Set the restore geometry after placing a ShellClient for the first time

Summary

The restore geometry gets initially set to 0/0xsize before the placement
is done. When going into updateClientArea and then afterwards into
AbstractClient::checkWorkspacePosition the geometry restory is used for
calculating the new position. This results in windows getting moved to
0/0 when e.g. plugging in a new screen or a panel changes, etc.

This change ensures that the restore geometry is set correctly after the
first placement.

BUG: 366696

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin updated this revision to Diff 6367.Aug 30 2016, 11:20 AM

graesslin retitled this revision from to Set the restore geometry after placing a ShellClient for the first time.

graesslin updated this object.

graesslin edited the test plan for this revision. (Show Details)

graesslin added reviewers: KWin, Plasma on Wayland, bshah.

Restricted Application added projects: Plasma on Wayland, KWin. · View Herald TranscriptAug 30 2016, 11:20 AM

Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

Fixwise good, APIwise, maybe add AbstractClient::placeIn(QRect &area) { Placement::self()->place(this, area); setGeometryRestore(geometry()); } to
a) prevent uninformed messing around with the restore geomery
b) guarantee sync behavior (when placing occurs)

In D2627#48943, @luebking wrote:

Fixwise good, APIwise, maybe add AbstractClient::placeIn(QRect &area) { Placement::self()->place(this, area); setGeometryRestore(geometry()); } to
a) prevent uninformed messing around with the restore geomery
b) guarantee sync behavior (when placing occurs)

?

yep makes sense.

Add a ShellClient::placeIn(QRect&) to provide the logic

luebking accepted this revision.Aug 31 2016, 12:37 PM

luebking added a reviewer: luebking.

This revision is now accepted and ready to land.Aug 31 2016, 12:37 PM

Closed by commit R108:d3741bd530cd: Set the restore geometry after placing a ShellClient for the first time (authored by graesslin). · Explain WhyAug 31 2016, 1:13 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/integration/plasma_surface_test.cpp (1 line)
M			shell_client.h (3 lines)
M			shell_client.cpp (8 lines)
M			workspace.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	6367	f99a456		Aug 30 2016, 11:20 AM	★	★
Diff 2	6383	f99a456	Add a ShellClient::placeIn(QRect&) to provide the logic	Aug 31 2016, 12:05 PM	★	★
Diff 3	6387	997cf97	rKWINd3741bd530cdd20eccb09f7f6e960d4c2465ac3a	Aug 31 2016, 1:12 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
fdf8154027b6	0e7b40d255ce	f99a456f3302	Martin Gräßlin	Set the restore geometry after placing a ShellClient for the first time (Show More…)	Aug 30 2016, 11:16 AM