remove the added space at the end

remove added space

add a comment to specify what this line does, the name of the function is not relevant enough to understand what it does.

Why not directly use the Qt function to do this (https://doc.qt.io/qt-5/qml-qtqml-number.html)?

is this attribute really useful?

can you replace all of these with:

//: first number is the minimum number and second the maximum number
qsTr("Guess a number between %1 and %2").arg(1).arg(25)?

This way, translators will only have one string to translate and this could avoid a lot of typo.

What would be the best (but not sure if it works) would be to be able to use the minNumber/maxNumber directly, something like:

qsTr("Guess a number between %1 and %2").arg(minNumber).arg(maxNumber)

add a newline at the end of the file

Hi @jjazeix ,

By using the Qt function it by default shows '0' in user entry text box at the beginning and the '0' gets overwrites when we type. So, there is always a zero at beginning. And it gives output with commas instead of spaces after a group of 3 digits. So if you allow should I go with the Qt function or let it be with the js function ?

Thanks

Hi, @jjazeix

Should I use

qsTr("Guess a number between %1 and %2").arg(minNumber).arg(maxNumber)

in js file as min and maxNumber can be accessed from there and also then there will be no use of objective and we can delete the objective attribute as well and instead of hard coding the values of max and min in data file it will be easier. Should I do this ?

Thanks

It gives comma because you are using a locale that uses commas as separator. It should use the same locale as GCompris.
For the initial zero, can't you do a check on the string's emptiness?

No, the aim is to have the objectives in the Data.qml files by dataset directly. The final goal of multiple dataset will be to be able to directly load new datasets dynamically without having to compile again the application so we don't want them in the js directly.
If it is not possible directly in the Data.qml, let's keep it this way.

trailing spaces

you have to use the locale used in GCompris, not the one of the computer

it's an integer so it's better to declare it as integer than var

indentation

It should be dependent on the dataset max value (and handle well the scale), not hardcoded.
Maybe it would be nice to only have a max number of displayed values (5 or 10) and round, for example for first dataset, and the plane moves accordingly:

this does not scale well (if you have a small screen, you don't see the last numbers)

indentation

indentation + use GCText for texts (to have the good font used)

make the visibility of the item a variable of the dataset, we don't want hardcode depending on the dataset in the common code

Suppose we have our first dataset as

1. 1 - 10
2. 1 - 15
3. 1 - 20

So it should display only max number of displayed numbers means 10 in 1 - 10 level or numbers till 10 or 10 15 20 should be displayed on every level ?

the max should be the maximum of the question, not the dataset (so 10, 15, 20 for your example).

so 10 15 20 as in the example should be displayed on all the levels(i.e 3 levels for first dataset) ? But then what is the need of displaying these to every level ? allon suggested that the suite should contain numbers from which the child can take help.

why not keeping the binding?

indentation

indentation

there is no need to check it there, you already access it before so if it is undefined, it will "crash" before

the imports of QtQuick and GCompris are not needed, you can remove them

can you also put here qsTr("Guess a number between 1 and %1").arg(1000) and improve it so digits are also grouped by 3 depending on locale? This way we are coherent in both the questions and answers

There is still this thing that I'd like to be fixed.
By removing the binding on "text: answerBackground.userEntry", it does not reset the plane at the end of the level to the screen.
Putting back the binding almost works fine, but there are issues when typing 0 that should be ignored if the answer if empty (if you type 0 twice at first level, you can't erase the actual number by typing 2 for example).
Can you take a look at this?