Differential D26147

Kickoff computer tab : don't display filepath for places in description
ClosedPublic
Actions

Authored by meven on Dec 21 2019, 5:38 PM.

Details

Reviewers
ngraham
hein
Group Reviewers
Plasma
VDG
Commits
R120:861e465951a0: Kickoff computer tab : don't display filepath for places in description
Summary

The path of places is not very informative to users
Follow the path of D26121

Test Plan

Diff Detail

Repository
R120 Plasma Workspace
Branch
arcpatch-D26147
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20178
Build 20196: arc lint + arc unit
meven created this revision.Dec 21 2019, 5:38 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 21 2019, 5:38 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
meven requested review of this revision.Dec 21 2019, 5:38 PM
ngraham accepted this revision.Dec 21 2019, 7:22 PM

Much clearer.

This revision is now accepted and ready to land.Dec 21 2019, 7:22 PM
hein requested changes to this revision.Dec 22 2019, 4:22 PM
hein added a subscriber: hein.

The return QString() shouldn't be necessary if we just fall through to the final return.

This revision now requires changes to proceed.Dec 22 2019, 4:22 PM
meven updated this revision to Diff 72041.Dec 23 2019, 8:26 AM

Use default fallthrough

hein accepted this revision.Jan 2 2020, 6:16 PM
This revision is now accepted and ready to land.Jan 2 2020, 6:16 PM
Closed by commit R120:861e465951a0: Kickoff computer tab : don't display filepath for places in description (authored by meven). · Explain WhyJan 2 2020, 9:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 72041

View Options

applets/kicker/plugin/computermodel.cpp

Loading...