Differential D26145

Port QRegExp to QRegularExpression
ClosedPublic
Actions

Authored by ahmadsamir on Dec 21 2019, 4:32 PM.

Details

Reviewers
mlaurent
vkrause
apol
Maniphest Tasks
T12279: Port frameworks away from QRegExp
Commits
R174:66ed335757c5: Port QRegExp to QRegularExpression
Summary

With QRegularExpression \x escape sequences that use more than two
hex digists have be in the form \x{nnnn}.

Test Plan

make && ctest
All unit tests pass except kcontacts-addresstest, but it fails with the
same exact error on master too, so it's not any worse.

Diff Detail

Repository
R174 KContacts
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahmadsamir created this revision.Dec 21 2019, 4:32 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 21 2019, 4:32 PM
ahmadsamir requested review of this revision.Dec 21 2019, 4:32 PM
ahmadsamir updated this revision to Diff 71995.Dec 22 2019, 2:26 PM

Link to KF6 task

apol accepted this revision.Dec 23 2019, 2:14 AM
This revision is now accepted and ready to land.Dec 23 2019, 2:14 AM
Closed by commit R174:66ed335757c5: Port QRegExp to QRegularExpression (authored by ahmadsamir). · Explain WhyDec 23 2019, 6:27 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/addressee.cpp (4 lines)

Diff 72038

View Options

src/addressee.cpp

Loading...