Differential D26136

Port QRegExp to QRegularExpression
ClosedPublic
Actions

Authored by ahmadsamir on Dec 20 2019, 10:13 PM.

Details

Reviewers
apol
Group Reviewers
Frameworks
Commits
R265:05ea3d2926e7: Port QRegExp to QRegularExpression
Summary

The intention is to replace consecutive empty lines, i.e. two or more \n chars, with one empty line.

Test Plan

make && ctest

Diff Detail

Repository
R265 KConfigWidgets
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahmadsamir created this revision.Dec 20 2019, 10:13 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 20 2019, 10:13 PM
ahmadsamir requested review of this revision.Dec 20 2019, 10:13 PM
apol added a subscriber: apol.Dec 23 2019, 2:03 AM

I'm a bit confused as to why the regex needs to be different. Explain in the commit message?

ahmadsamir updated this revision to Diff 72035.Dec 23 2019, 6:19 AM

Explain why the regex was changed

ahmadsamir added a comment.Dec 23 2019, 6:20 AM
In D26136#581721, @apol wrote:

I'm a bit confused as to why the regex needs to be different. Explain in the commit message?

Fair point. Done.

apol added a comment.Dec 23 2019, 12:51 PM

It didn't update here?

ahmadsamir updated this revision to Diff 72083.Dec 23 2019, 1:20 PM

Verbatim, take 2, with Summary: added manually

ahmadsamir edited the summary of this revision. (Show Details)Dec 23 2019, 1:23 PM
In D26136#582140, @ahmadsamir wrote:

Verbatim, take 2, with Summary: added manually

In D26136#582140, @ahmadsamir wrote:

Verbatim, take 2, with Summary: added manually

Even that didn't work, had to use the web ui to edit the summary, phabricator special behaviour...

apol accepted this revision.Dec 23 2019, 2:49 PM
This revision is now accepted and ready to land.Dec 23 2019, 2:49 PM
Closed by commit R265:05ea3d2926e7: Port QRegExp to QRegularExpression (authored by ahmadsamir). · Explain WhyJan 5 2020, 9:53 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/ktipdialog.cpp (3 lines)

Diff 72781

View Options

src/ktipdialog.cpp

Loading...