Ship plasma-logo in repo
ClosedPublic

Authored by davidre on Dec 18 2019, 9:18 AM.

Details

Summary

We don't want the plasma-logo on the homepage to be changed to something else by
the icon theme. It's not used like an icon but as a logo and should always
display our brand.
BUG: 415173

Test Plan

Open systemsettings with different icon and color themes

Diff Detail

Repository
R124 System Settings
Branch
icon (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20005
Build 20023: arc lint + arc unit
davidre created this revision.Dec 18 2019, 9:18 AM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 18 2019, 9:18 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidre requested review of this revision.Dec 18 2019, 9:18 AM
davidre edited the summary of this revision. (Show Details)Dec 18 2019, 9:19 AM
davidre edited the test plan for this revision. (Show Details)
davidre added reviewers: Plasma, GB_2.

+1 for the concept, but will this implementation work for users? Should we maybe use the QRC mechanism instead?

+1 for the concept, but will this implementation work for users? Should we maybe use the QRC mechanism instead?

This should work for the users. Qt.resolvedUrl will return a url relative to the caller (https://doc.qt.io/qt-5/qml-qtqml-qt.html#resolvedUrl-method). The whole package is installed as is to the user system.

ngraham accepted this revision.Dec 19 2019, 4:08 PM
This revision is now accepted and ready to land.Dec 19 2019, 4:08 PM
GB_2 accepted this revision as: GB_2.Dec 20 2019, 12:17 PM
This revision was automatically updated to reflect the committed changes.