Differential D26074

Port away from depreacted IconSize() method
ClosedPublic
Actions

Authored by vkrause on Dec 17 2019, 7:23 PM.

Details

Reviewers
mlaurent
Maniphest Tasks
T11637: KIconThemes Cleanups
Commits
R362:c20ab5b984b1: Port away from depreacted IconSize() method

Diff Detail

Repository
R362 KWalletManager
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19992
Build 20010: arc lint + arc unit
vkrause created this revision.Dec 17 2019, 7:23 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald TranscriptDec 17 2019, 7:23 PM
vkrause requested review of this revision.Dec 17 2019, 7:23 PM
mlaurent accepted this revision.Dec 18 2019, 6:45 PM
This revision is now accepted and ready to land.Dec 18 2019, 6:45 PM
Closed by commit R362:c20ab5b984b1: Port away from depreacted IconSize() method (authored by vkrause). · Explain WhyDec 18 2019, 6:50 PM
This revision was automatically updated to reflect the committed changes.
cfeck added a subscriber: cfeck.EditedJan 5 2020, 4:55 AM

The stable branch "release/19.12" for kwalletmanager fails to build. Does this need to be backported for the coming 19.12.1 release?

See https://build.kde.org/job/Applications/view/Everything%20-%20stable-kf5-qt5/job/kwalletmanager/

vkrause added a comment.Jan 5 2020, 10:49 AM
In D26074#587793, @cfeck wrote:

The stable branch "release/19.12" for kwalletmanager fails to build. Does this need to be backported for the coming 19.12.1 release?

I'd rather argue stable branches should not disable deprecated API in future versions. Fix pushed, CI is green again.

Revision Contents
Changeset List

PathPackages
Msrc/manager/allyourbase.cpp (7 lines)

Diff 71746

View Options

src/manager/allyourbase.cpp

Loading...