Port away from depreacted IconSize() method
ClosedPublic

Authored by vkrause on Dec 17 2019, 7:23 PM.

Diff Detail

Repository
R362 KWalletManager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Dec 17 2019, 7:23 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald TranscriptDec 17 2019, 7:23 PM
vkrause requested review of this revision.Dec 17 2019, 7:23 PM
mlaurent accepted this revision.Dec 18 2019, 6:45 PM
This revision is now accepted and ready to land.Dec 18 2019, 6:45 PM
This revision was automatically updated to reflect the committed changes.
cfeck added a subscriber: cfeck.EditedJan 5 2020, 4:55 AM

The stable branch "release/19.12" for kwalletmanager fails to build. Does this need to be backported for the coming 19.12.1 release?

See https://build.kde.org/job/Applications/view/Everything%20-%20stable-kf5-qt5/job/kwalletmanager/

The stable branch "release/19.12" for kwalletmanager fails to build. Does this need to be backported for the coming 19.12.1 release?

I'd rather argue stable branches should not disable deprecated API in future versions. Fix pushed, CI is green again.