Differential D26055

Enable wheel events on Slider {}
ClosedPublic
Actions

Authored by apol on Dec 16 2019, 4:43 PM.

Details

Reviewers
broulik
davidedmundson
Group Reviewers
Plasma
Commits
R242:66122410a11d: Enable wheel events on Slider {}
Summary

So far PC3 version of the slider doesn't react to events, this change
enables it.

Test Plan

Used it with a test.

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Dec 16 2019, 4:43 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 16 2019, 4:43 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
apol requested review of this revision.Dec 16 2019, 4:43 PM
davidedmundson added a subscriber: davidedmundson.Dec 16 2019, 8:24 PM

Used it with a test.

What test?
I just noticed it's missing from p-f/tests/components

davidedmundson accepted this revision.Dec 16 2019, 8:25 PM
This revision is now accepted and ready to land.Dec 16 2019, 8:25 PM
apol updated this revision to Diff 71741.Dec 17 2019, 6:15 PM

Include test

apol updated this revision to Diff 71742.Dec 17 2019, 6:25 PM

don't show too many ticks

apol updated this revision to Diff 71744.Dec 17 2019, 7:00 PM

Just never draw over 20 ticks

Closed by commit R242:66122410a11d: Enable wheel events on Slider {} (authored by apol). · Explain WhyDec 30 2019, 5:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 72405

View Options

src/declarativeimports/plasmacomponents3/Slider.qml

Loading...
View Options

tests/components/slider3.qml

Loading...