Restore circular progress bar in compact notification applet
ClosedPublic

Authored by ahiemstra on Dec 15 2019, 10:29 AM.

Details

Summary

During the port to Qt5 the circular progress bar was lost, since there is no
simple way to do circular progress bars. Now that KQuickCharts is available
as a framework, we can restore the circular progress bar in the notifications.

Video:

Test Plan

Start a long-ish running job like copying a file.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahiemstra created this revision.Dec 15 2019, 10:29 AM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 15 2019, 10:29 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ahiemstra requested review of this revision.Dec 15 2019, 10:29 AM
ahiemstra edited the summary of this revision. (Show Details)Dec 15 2019, 10:31 AM
broulik requested changes to this revision.Dec 15 2019, 10:35 AM
broulik added a subscriber: broulik.
broulik added inline comments.
applets/notifications/package/contents/ui/CompactRepresentation.qml
107

You might want to stop and hide the BusyIndicator altogether (cf. the State below) rather than just making it fully transparent

This revision now requires changes to proceed.Dec 15 2019, 10:35 AM
ahiemstra updated this revision to Diff 71579.Dec 15 2019, 10:46 AM
  • Use visible to hide the busyindicator when progress > 0
ahiemstra updated this revision to Diff 71584.Dec 15 2019, 11:14 AM
  • Don't show busyindicator when there are no jobs
broulik accepted this revision.Dec 15 2019, 11:24 AM

Lovely!

This revision is now accepted and ready to land.Dec 15 2019, 11:24 AM
This revision was automatically updated to reflect the committed changes.