Differential D25967

Emit panelTakesFocus for other plamsashell types
AbandonedPublic
Actions

Authored by davidedmundson on Dec 13 2019, 8:25 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Summary

The semantics of a window taking focus on user interaction apply to more
roles. See D25851.

Arguably the name implies something more limited, but it makes sense to
reuse the existing logic.

Diff Detail

Repository
R130 Frameworks integration plugin using KWayland
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19810
Build 19828: arc lint + arc unit
davidedmundson created this revision.Dec 13 2019, 8:25 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 13 2019, 8:25 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Dec 13 2019, 8:25 PM
apol added a subscriber: apol.EditedDec 14 2019, 10:18 PM

I'm not sure that I'm misunderstanding, does this mean that notifications might steal focus?
Is it only that it _might_ take focus?

broulik added a subscriber: broulik.Dec 15 2019, 8:50 AM

No! But it allows them to get it if they want to, e.g. when you hit inline reply

mart accepted this revision.Dec 15 2019, 5:52 PM
This revision is now accepted and ready to land.Dec 15 2019, 5:52 PM
davidedmundson planned changes to this revision.Dec 15 2019, 5:57 PM

In hindsight, lets see if we can get something that fixes the widget explorer at the same time. It's basically the same issue.

davidedmundson abandoned this revision.Mar 29 2020, 3:17 PM

Revision Contents
Changeset List

PathPackages
Msrc/windowsystem/windowsystem.cpp (5 lines)

Diff 71473

View Options

src/windowsystem/windowsystem.cpp

Loading...